Re: [PATCH v4 4/7] lib/hexdump.c: Replace ascii bool in hex_dump_to_buffer with flags
From: Alastair D'Silva <hidden>
Date: 2019-06-26 01:28:38
Also in:
dri-devel, intel-gfx, linux-fbdev, linux-fsdevel, linux-scsi, linux-wireless, lkml
On Mon, 2019-06-24 at 22:19 -0700, Joe Perches wrote:
On Tue, 2019-06-25 at 15:06 +1000, Alastair D'Silva wrote:quoted
The change actions Jani's suggestion: https://lkml.org/lkml/2019/6/20/343I suggest not changing any of the existing uses of hex_dump_to_buffer and only use hex_dump_to_buffer_ext when necessary for your extended use cases.
I disagree, adding a wrapper for the benefit of avoiding touching a handful of call sites that are easily amended would be adding technical debt. -- Alastair D'Silva mob: 0423 762 819 skype: alastair_dsilva Twitter: @EvilDeece blog: http://alastair.d-silva.org