Re: [PATCH net-next v2 1/4] net/sched: Introduce action ct
From: Paul Blakey <hidden>
Date: 2019-06-30 08:45:38
On 6/27/2019 10:53 PM, David Miller wrote:
From: Paul Blakey <redacted> Date: Thu, 20 Jun 2019 16:42:18 +0300quoted
+struct tcf_ct_params {...quoted
+ struct rcu_head rcu; + +};Please get ride of that empty line after the 'rcu' member.quoted
+ switch (skb->protocol) { + case htons(ETH_P_IP): + family = NFPROTO_IPV4; + break; + case htons(ETH_P_IPV6): + family = NFPROTO_IPV6; + break; + default: + break;Break statement is not indented properly.quoted
+static __net_init int ct_init_net(struct net *net) +{ + struct tc_ct_action_net *tn = net_generic(net, ct_net_id); + unsigned int n_bits = FIELD_SIZEOF(struct tcf_ct_params, labels) * 8;Reverse christmas tree here please.
Sure thanks.