Thread (9 messages) flat view 9 messages, 4 authors, 2019-07-02

Re: [Patch net 2/3] idr: introduce idr_for_each_entry_continue_ul()

From: Davide Caratti <hidden>
Date: 2019-06-28 21:14:57

On Fri, 2019-06-28 at 11:03 -0700, Cong Wang wrote:
Similarly, other callers of idr_get_next_ul() suffer the same
overflow bug as they don't handle it properly either.

Introduce idr_for_each_entry_continue_ul() to help these callers
iterate from a given ID.

cls_flower needs more care here because it still has overflow when
does arg->cookie++, we have to fold its nested loops into one
and remove the arg->cookie++.
hello Cong,

I confirm that this patch fixes the infinite loop when dumping TC flower
rule with handle 0xffffffff on kernel 5.2.0-0.rc5.git0.1.fc31.i686.

Tested-by: Davide Caratti <redacted>

thanks!
-- 
davide
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help