Re: [net-next 1/4] gve: Add basic driver framework for Compute Engine Virtual NIC
From: Jakub Kicinski <hidden>
Date: 2019-06-28 18:46:21
From: Jakub Kicinski <hidden>
Date: 2019-06-28 18:46:21
On Fri, 28 Jun 2019 10:52:27 -0700, Catherine Sullivan wrote:
quoted
quoted
+if NET_VENDOR_GOOGLE + +config GVE + tristate "Google Virtual NIC (gVNIC) support" + depends on (PCI_MSI && X86)We usually prefer for drivers not to depend on the platform unless really necessary, but IDK how that applies to the curious new world of NICs nobody can buy :)This is the only platform it will ever need to run on so we would really prefer to not have to support others :)
I think the motivation is partially to force the uniform use of generic APIs across the drivers, so that re-factoring of core code is easier. Do you have any specific pain-points in mind where x86 dependency simplifies things? If not I think it's a better default to not have it. Not a big deal, though.