Re: [PATCH v2 net-next 5/5] ipv6: convert major tx path to use RT6_LOOKUP_F_DST_NOREF

From
Wei Wang <hidden>
Date
2019-06-19 23:29:09
Reply to
David Ahern, 2019-06-19
On Wed, Jun 19, 2019 at 4:21 PM David Ahern [off-list ref] wrote:
On 6/19/19 4:31 PM, Wei Wang wrote:
quoted
diff --git a/include/net/l3mdev.h b/include/net/l3mdev.h
index e942372b077b..d8c37317bb86 100644
--- a/include/net/l3mdev.h
+++ b/include/net/l3mdev.h
@@ -31,8 +31,9 @@ struct l3mdev_ops {
                                        u16 proto);

      /* IPv6 ops */
-     struct dst_entry * (*l3mdev_link_scope_lookup)(const struct net_device *dev,
-                                              struct flowi6 *fl6);
+     struct dst_entry * (*l3mdev_link_scope_lookup_noref)(
+                                         const struct net_device *dev,
+                                         struct flowi6 *fl6);
I would prefer to add a comment about not taking a references vs adding
the _noref extension. There is only 1 user for 1 context and the name
length is getting out of hand (as evidenced by the line wrapping below).
Hmm OK. I was trying to make it clear to make sure future callers do
not misuse it.
Thread (12 messages) 12 messages, 4 authors, last reply 2019-06-21
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help