Re: [PATCH net-next 3/5] ipv6: honor RT6_LOOKUP_F_DST_NOREF in rule lookup logic

From
Wei Wang <hidden>
Date
2019-06-19 16:51:43
Reply to
David Miller, 2019-06-19
On Wed, Jun 19, 2019 at 9:07 AM David Miller [off-list ref] wrote:
From: Wei Wang <redacted>
Date: Tue, 18 Jun 2019 11:25:41 -0700
quoted
@@ -237,13 +240,16 @@ static int __fib6_rule_action(struct fib_rule *rule, struct flowi *flp,
                      goto out;
      }
 again:
-     ip6_rt_put(rt);
+     if (!(flags & RT6_LOOKUP_F_DST_NOREF) ||
+         !list_empty(&rt->rt6i_uncached))
+             ip6_rt_put(rt);
This conditional release logic, with the special treatment of uncache items
when using DST_NOREF, seems error prone.

Maybe you can put this logic into a helper like ip6_rt_put_any() and do the
list empty test etc. there?

        ip6_rt_put_any(struct rt6_info *rt, int flags);

What do you think?
Thanks David. Sure. Will update.
Thread (9 messages) 9 messages, 4 authors, last reply 2019-06-20
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help