Re: [PATCH v5 net] sctp: Free cookie before we memdup a new one
From: David Miller <davem@davemloft.net>
Date: 2019-06-15 02:28:02
Also in:
linux-sctp
From: Neil Horman <nhorman@tuxdriver.com> Date: Thu, 13 Jun 2019 06:35:59 -0400
Based on comments from Xin, even after fixes for our recent syzbot report of cookie memory leaks, its possible to get a resend of an INIT chunk which would lead to us leaking cookie memory. To ensure that we don't leak cookie memory, free any previously allocated cookie first. Change notes v1->v2 update subsystem tag in subject (davem) repeat kfree check for peer_random and peer_hmacs (xin) v2->v3 net->sctp also free peer_chunks v3->v4 fix subject tags v4->v5 remove cut line Signed-off-by: Neil Horman <nhorman@tuxdriver.com> Reported-by: syzbot+f7e9153b037eac9b1df8@syzkaller.appspotmail.com
Applied, thanks.