Re: [PATCH] staging: isdn: To make hysdn_proc_entry static.
From: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>
Date: 2019-06-09 10:59:20
On Sun, Jun 09, 2019 at 12:24:59AM +0000, Rishiraj Manwatkar wrote:
Made hysdn_proc_entry static as suggested by Sparse tool.
Why is this indented?
quoted hunk
Signed-off-by: Rishiraj Manwatkar <redacted> --- drivers/staging/isdn/hysdn/hysdn_procconf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/drivers/staging/isdn/hysdn/hysdn_procconf.c b/drivers/staging/isdn/hysdn/hysdn_procconf.c index 73079213ec94..3d12c058a6f1 100644 --- a/drivers/staging/isdn/hysdn/hysdn_procconf.c +++ b/drivers/staging/isdn/hysdn/hysdn_procconf.c@@ -349,7 +349,7 @@ static const struct file_operations conf_fops = /*****************************/ /* hysdn subdir in /proc/net */ /*****************************/ -struct proc_dir_entry *hysdn_proc_entry = NULL; +static struct proc_dir_entry *hysdn_proc_entry = NULL;
I will have to wait until after 5.3-rc1 before taking any drivers/staging/isdn patches, sorry. I suggest waiting until then before resending, and even then, the isdn code is about to be deleted, try working on code that is being accepted. thanks, greg k-h