Re: [PATCH net] pktgen: do not sleep with the thread lock held.
From: David Miller <davem@davemloft.net>
Date: 2019-06-05 19:06:01
From: Paolo Abeni <pabeni@redhat.com> Date: Wed, 5 Jun 2019 14:34:46 +0200
quoted hunk ↗ jump to hunk
@@ -3062,20 +3062,49 @@ static int thread_is_running(const struct pktgen_thread *t) return 0; } -static int pktgen_wait_thread_run(struct pktgen_thread *t) +static bool pktgen_lookup_thread(struct pktgen_net *pn, struct pktgen_thread *t) +{ + struct pktgen_thread *tmp; + + list_for_each_entry(tmp, &pn->pktgen_threads, th_list) + if (tmp == t) + return true; + return false; +}
Pointer equality is not object equality. It is possible for a pktgen thread to be terminated, a new one started, and the new one to have the same pointer value as the old one.