Re: [net-next v2] hinic: add LRO support
From: David Miller <davem@davemloft.net>
Date: 2019-05-31 21:53:07
Also in:
lkml
From: Xue Chaojing <redacted> Date: Fri, 31 May 2019 05:47:30 +0000
+ if ((err) || (out_param)) {Too many parenthesis, just "if (err || out_param)" is fine.
quoted hunk ↗ jump to hunk
@@ -51,6 +51,22 @@ static unsigned int rx_weight = 64; module_param(rx_weight, uint, 0644); MODULE_PARM_DESC(rx_weight, "Number Rx packets for NAPI budget (default=64)"); +static unsigned int set_lro_timer = 16; +module_param(set_lro_timer, uint, 0444); +MODULE_PARM_DESC(set_lro_timer, "Set lro timer in micro second, valid range is 1 - 1024, default is 16");
I also said your changes were a non-starter with all of these module parameters. I am not looking at this patch until you find a way to remove them. Thank you.