Thread (7 messages) 7 messages, 2 authors, 2019-05-31

Re: [PATCH v2 2/5] net: qrtr: Implement outgoing flow control

From: David Miller <davem@davemloft.net>
Date: 2019-05-31 21:46:38
Also in: linux-arm-msm, lkml

From: Bjorn Andersson <redacted>
Date: Thu, 30 May 2019 18:17:50 -0700
+	flow = radix_tree_lookup(&node->qrtr_tx_flow, key);
+	if (flow)
+		atomic_set(&flow->pending, 0);
You can't just zero out an atomic counter without extra synchronization
which protects you from the increment paths.

And since you'll need a lock to cover all of those paths, you don't
need to use an atomic_t and instead can use a plain integer.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help