Thread (3 messages) 3 messages, 3 authors, 2019-06-25

Re: [PATCH] rtlwifi: remove redundant assignment to variable badworden

From: Larry Finger <hidden>
Date: 2019-05-30 18:50:07
Also in: kernel-janitors, linux-wireless, lkml

On 5/30/19 1:40 PM, Colin King wrote:
From: Colin Ian King <redacted>

The variable badworden is assigned with a value that is never read and
it is re-assigned a new value immediately afterwards.  The assignment is
redundant and can be removed.

Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King <redacted>
---
Acked-by: Larry Finger <redacted>

Thanks,

Larry
quoted hunk ↗ jump to hunk
  drivers/net/wireless/realtek/rtlwifi/efuse.c | 1 -
  1 file changed, 1 deletion(-)
diff --git a/drivers/net/wireless/realtek/rtlwifi/efuse.c b/drivers/net/wireless/realtek/rtlwifi/efuse.c
index e68340dfd980..37ab582a8afb 100644
--- a/drivers/net/wireless/realtek/rtlwifi/efuse.c
+++ b/drivers/net/wireless/realtek/rtlwifi/efuse.c
@@ -986,7 +986,6 @@ static int efuse_pg_packet_write(struct ieee80211_hw *hw,
  		} else if (write_state == PG_STATE_DATA) {
  			RTPRINT(rtlpriv, FEEPROM, EFUSE_PG,
  				"efuse PG_STATE_DATA\n");
-			badworden = 0x0f;
  			badworden =
  			    enable_efuse_data_write(hw, efuse_addr + 1,
  						    target_pkt.word_en,
  
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help