Re: [PATCH v2] sdio: Fix a memory leaking bug in wl1271_probe()
From: Kalle Valo <hidden>
Date: 2019-05-23 15:00:29
Also in:
linux-wireless, lkml
Possibly related (same subject, not in this thread)
- 2019-06-05 · Re: [PATCH v2] sdio: Fix a memory leaking bug in wl1271_probe() · Jiri Slaby <hidden>
- 2019-05-23 · [PATCH v2] sdio: Fix a memory leaking bug in wl1271_probe() · Gen Zhang <hidden>
+ linux-wireless Gen Zhang [off-list ref] writes:
quoted hunk
In wl1271_probe(), 'glue->core' is allocated by platform_device_alloc(), when this allocation fails, ENOMEM is returned. However, 'pdev_data' and 'glue' are allocated by devm_kzalloc() before 'glue->core'. When platform_device_alloc() returns NULL, we should also free 'pdev_data' and 'glue' before wl1271_probe() ends to prevent leaking memory. Similarly, we should free 'pdev_data' when 'glue' is NULL. And we should free 'pdev_data' and 'glue' when 'ret' is error. Further, we shoulf free 'glue->dev', 'pdev_data' and 'glue' when this function normally ends to prevent memory leaking. Signed-off-by: Gen Zhang <redacted> ---diff --git a/drivers/net/wireless/ti/wlcore/sdio.c b/drivers/net/wireless/ti/wlcore/sdio.c index 4d4b0770..232ce5f 100644 --- a/drivers/net/wireless/ti/wlcore/sdio.c +++ b/drivers/net/wireless/ti/wlcore/sdio.c
You need to CC linux-wireless, otherwise patchwork won't see the patch and it will not be applied. Also you should use prefix "wlcore:". https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches#commit_title_is_wrong -- Kalle Valo