Thread (3 messages) 3 messages, 2 authors, 2019-05-20

Re: [PATCH net-next] macvlan: Mark expected switch fall-through

From: David Miller <davem@davemloft.net>
Date: 2019-05-20 18:38:15
Also in: lkml

From: "Gustavo A. R. Silva" <redacted>
Date: Mon, 20 May 2019 09:44:49 -0500
In preparation to enabling -Wimplicit-fallthrough, mark switch
cases where we are expecting to fall through.

This patch fixes the following warning:

drivers/net/macvlan.c: In function ‘macvlan_do_ioctl’:
drivers/net/macvlan.c:839:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
   if (!net_eq(dev_net(dev), &init_net))
      ^
drivers/net/macvlan.c:841:2: note: here
  case SIOCGHWTSTAMP:
  ^~~~

Warning level 3 was used: -Wimplicit-fallthrough=3

This patch is part of the ongoing efforts to enable
-Wimplicit-fallthrough.

Signed-off-by: Gustavo A. R. Silva <redacted>
I'll apply this to 'net' since it was introduced actually by arecent
change.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help