Thread (2 messages) flat view 2 messages, 2 authors, 2019-05-17

RE: [Intel-wired-lan] [PATCH][next] i40e: mark expected switch fall-through

From: Bowers, AndrewX <hidden>
Date: 2019-05-17 22:36:50
Also in: intel-wired-lan, lkml

-----Original Message-----
From: Intel-wired-lan [mailto:intel-wired-lan-bounces@osuosl.org] On
Behalf Of Gustavo A. R. Silva
Sent: Wednesday, May 1, 2019 1:56 PM
To: Kirsher, Jeffrey T <redacted>; David S. Miller
[off-list ref]
Cc: netdev@vger.kernel.org; intel-wired-lan@lists.osuosl.org; linux-
kernel@vger.kernel.org; Kees Cook [off-list ref]
Subject: [Intel-wired-lan] [PATCH][next] i40e: mark expected switch fall-
through

In preparation to enabling -Wimplicit-fallthrough, mark switch cases where
we are expecting to fall through.

This patch fixes the following warning:

drivers/net/ethernet/intel/i40e/i40e_xsk.c: In function ‘i40e_run_xdp_zc’:
drivers/net/ethernet/intel/i40e/i40e_xsk.c:217:3: warning: this statement
may fall through [-Wimplicit-fallthrough=]
   bpf_warn_invalid_xdp_action(act);
   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/net/ethernet/intel/i40e/i40e_xsk.c:218:2: note: here
  case XDP_ABORTED:
  ^~~~

In preparation to enabling -Wimplicit-fallthrough, mark switch cases where
we are expecting to fall through.

This patch fixes the following warning:

Signed-off-by: Gustavo A. R. Silva <redacted>
---
 drivers/net/ethernet/intel/i40e/i40e_xsk.c | 1 +
 1 file changed, 1 insertion(+)
Tested-by: Andrew Bowers <redacted>

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help