Re: [PATCH net-next v2 0/4] of_get_mac_address ERR_PTR fixes
From: Geert Uytterhoeven <geert@linux-m68k.org>
Date: 2019-05-07 09:07:52
Also in:
linux-arm-kernel, linux-mediatek, linux-renesas-soc, lkml
Hi Petr, On Mon, May 6, 2019 at 11:25 PM Petr Štetiar [off-list ref] wrote:
this patch series is an attempt to fix the mess, I've somehow managed to introduce. First patch in this series is defacto v5 of the previous 05/10 patch in the series, but since the v4 of this 05/10 patch wasn't picked up by the patchwork for some unknown reason, this patch wasn't applied with the other 9 patches in the series, so I'm resending it as a separate patch of this fixup series again. Second patch is a result of this rebase against net-next tree, where I was checking again all current users of of_get_mac_address and found out, that there's new one in DSA, so I've converted this user to the new ERR_PTR encoded error value as well. Third patch which was sent as v5 wasn't considered for merge, but I still think, that we need to check for possible NULL value, thus current IS_ERR check isn't sufficient and we need to use IS_ERR_OR_NULL instead. Fourth patch fixes warning reported by kbuild test robot. Cheers, Petr Petr Štetiar (4): net: ethernet: support of_get_mac_address new ERR_PTR error
I didn't receive the patch through email, but patchwork does have it: https://patchwork.ozlabs.org/patch/1096054/ This fixes the crash ("Unable to handle kernel paging request atvirtual address fffffffe") I'm seeing with sh_eth on r8a7791/koelsch, so Tested-by: Geert Uytterhoeven <geert+renesas@glider.be> Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds