[RFC PATCH 1/6] seg6: Fix TLV definitions
From: Tom Herbert <hidden>
Date: 2019-05-31 16:50:04
Subsystem:
networking [srv6], the rest · Maintainers:
Andrea Mayer, Linus Torvalds
The definitions of TLVs in uapi/linux/seg6.h are incorrect and incomplete. Fix this. TLV constants are defined for PAD1, PADN, and HMAC (the three defined in draft-ietf-6man-segment-routing-header-19). The other TLV are unused and and are marked as obsoleted. Signed-off-by: Tom Herbert <redacted> --- include/uapi/linux/seg6.h | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-)
diff --git a/include/uapi/linux/seg6.h b/include/uapi/linux/seg6.h
index 286e8d6..9117113 100644
--- a/include/uapi/linux/seg6.h
+++ b/include/uapi/linux/seg6.h@@ -38,10 +38,13 @@ struct ipv6_sr_hdr { #define SR6_FLAG1_ALERT (1 << 4) #define SR6_FLAG1_HMAC (1 << 3) -#define SR6_TLV_INGRESS 1 -#define SR6_TLV_EGRESS 2 -#define SR6_TLV_OPAQUE 3 -#define SR6_TLV_PADDING 4 + +#define SR6_TLV_INGRESS 1 /* obsoleted */ +#define SR6_TLV_EGRESS 2 /* obsoleted */ +#define SR6_TLV_OPAQUE 3 /* obsoleted */ + +#define SR6_TLV_PAD1 0 +#define SR6_TLV_PADDING 1 #define SR6_TLV_HMAC 5 #define sr_has_hmac(srh) ((srh)->flags & SR6_FLAG1_HMAC)
--
2.7.4