Re: [PATCH V1 net-next 02/11] net: ena: ethtool: add extra properties retrieval via get_priv_flags
From: Jakub Kicinski <hidden>
Date: 2019-05-29 22:10:01
On Wed, 29 May 2019 12:49:55 +0300, sameehj@amazon.com wrote:
From: Arthur Kiyanovski <akiyano@amazon.com> This commit adds a mechanism for exposing different driver properties via ethtool's priv_flags. In this commit we: Add commands, structs and defines necessary for handling extra properties Add functions for: Allocation/destruction of a buffer for extra properties strings. Retreival of extra properties strings and flags from the network device. Handle the allocation of a buffer for extra properties strings. * Initialize buffer with extra properties strings from the network device at driver startup. Use ethtool's get_priv_flags to expose extra properties of the ENA device Signed-off-by: Arthur Kiyanovski <akiyano@amazon.com> Signed-off-by: Sameeh Jubran <redacted>
This commit DMAs in the string set blindly from the FW and exposes it to user space, without any interpretation by the driver, correct? Making the driver a mere proxy for the FW. I think it should be clearly mentioned in the commit message, to make sure we know what what we are accepting here. I'm always a little uncomfortable with such changes :) (I'm not actually sure there is a precedent for this).