Re: [PATCH net-next] sctp: remove unused cmd SCTP_CMD_GEN_INIT_ACK

On Thu, May 09, 2019 at 09:39:13AM -0700, David Miller wrote:

From: Neil Horman <nhorman@tuxdriver.com>
Date: Thu, 9 May 2019 07:32:35 -0400

quoted

This is definately a valid cleanup, but I wonder if it wouldn't be better to,
instead of removing it, to use it.  We have 2 locations where we actually call
sctp_make_init_ack, and then have to check the return code and abort the
operation if we get a NULL return.  Would it be a better solution (in the sense
of keeping our control flow in line with how the rest of the state machine is
supposed to work), if we didn't just add a SCTP_CMD_GEN_INIT_ACK sideeffect to
the state machine queue in the locations where we otherwise would call
sctp_make_init_ack/sctp_add_cmd_sf(...SCTP_CMD_REPLY)?

Also, net-next is closed 8-)

Details, details :)