Re: [PATCH] net: dsa: sja1105: Don't return a negative in u8 sja1105_stp_state_get
From: David Miller <davem@davemloft.net>
Date: 2019-05-08 20:58:15
Also in:
kernel-janitors
From: Vladimir Oltean <olteanv@gmail.com> Date: Wed, 8 May 2019 23:32:25 +0300
Dan Carpenter says:
The patch 640f763f98c2: "net: dsa: sja1105: Add support for Spanning
Tree Protocol" from May 5, 2019, leads to the following static
checker warning:
drivers/net/dsa/sja1105/sja1105_main.c:1073 sja1105_stp_state_get()
warn: signedness bug returning '(-22)'
The caller doesn't check for negative errors anyway.
Fixes: 640f763f98c2: ("net: dsa: sja1105: Add support for Spanning Tree Protocol")
Reported-by: Dan Carpenter <redacted>
Signed-off-by: Vladimir Oltean <olteanv@gmail.com>Applied.