Re: [PATCH 0/5] Beginnings of skb_frag -> bio_vec conversion

From
Eric Dumazet <hidden>
Date
2019-05-01 08:14:47
Reply to
Matthew Wilcox, 2019-05-01

On 4/30/19 9:17 PM, Matthew Wilcox wrote:
From: "Matthew Wilcox (Oracle)" <willy@infradead.org>

It turns out there's a lot of accessors for the skb_frag, which would
make this conversion really easy if some drivers didn't bypass them.
This is what I've done so far; my laptop's not really beefy enough to
cope with changing skbuff.h too often ;-)

This would be a great time to tell me I'm going about this all wrong.
I already found one problem in this patch set; some of the drivers should
have been converted to skb_frag_dma_map() instead of fixing the arguments
to dma_map_page().  But anyway, I need sleep.
I guess the missing part here is the "why" all this is done ?

32 bit hosts will have bigger skb_shared_info and this impacts sk_rcvbuf and sk_sndbuf limits.

17 * 4 are 68 extra bytes per skb.
Thread (9 messages) 9 messages, 3 authors, last reply 2019-05-02
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help