Thread (28 messages) 28 messages, 7 authors, 2019-04-25

Re: [PATCH v3 02/26] compat_ioctl: move simple ppp command handling into driver

From: Al Viro <viro@zeniv.linux.org.uk>
Date: 2019-04-18 05:57:26
Also in: linux-fsdevel, lkml

On Thu, Apr 18, 2019 at 12:53:00AM +0100, Al Viro wrote:
Why would you want to duplicate large chunks of anything?
The above is not even compile-tested, but...  I can put
together a patch if you wish.  Or am I missing something
here?
Actually, there's another broken part - pppox.  And that one
is nastier - you've just lost everything outside of protocol
family ioctls on those sockets.  Try e.g.  SIOCGIFMTU in 32bit
process on those.

We really can't reuse native ->ioctl() there - proto family
->compat_ioctl() *must* return -ENOIOCTLCMD on everything it
doesn't handle.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help