Re: [PATCH net 1/2] thunderx: enable page recycling for non-XDP case

On 3/26/19 9:59 AM, Jesper Dangaard Brouer wrote:

On Tue, 26 Mar 2019 09:44:19 -0500
Dean Nelson [off-list ref] wrote:

quoted

On 3/26/19 9:39 AM, Jesper Dangaard Brouer wrote:

quoted

On Tue, 26 Mar 2019 10:04:47 -0400
Dean Nelson [off-list ref] wrote:
   

quoted

Commit 773225388dae15e72790 added code to nicvf_alloc_page() that inadvertently
disables receive buffer page recycling for the non-XDP case by always NULL'ng
the page pointer.

This patch corrects two if-conditionals to allow for the recycling of non-XDP
mode pages by only setting the page pointer to NULL when the page is not ready
for recycling.

Signed-off-by: Dean Nelson <redacted>

You need to add a "fixes" line like this:

Fixes: 773225388dae ("net: thunderx: Optimize page recycling for XDP")

And in-general reference a commit in the same way in the description.

Sorry, for some reason I thought the 'Fixes' line was optional.

Thank you for setting me straight. Should I repost the patchset?

I would say, yes please. (Given the amount of patches DaveM have to
process, lets make it easy for him).

Would be glad to, as I definitely agree.
Thanks for responding to my question.