Thread (4 messages) 4 messages, 3 authors, 2019-03-28

RE: [PATCH hyperv-fixes,v2] hv_netvsc: Fix unwanted wakeup after tx_disable

From: Haiyang Zhang <haiyangz@microsoft.com>
Date: 2019-03-28 19:27:44
Also in: linux-hyperv, lkml

-----Original Message-----
From: linux-hyperv-owner@vger.kernel.org <linux-hyperv-
owner@vger.kernel.org> On Behalf Of David Miller
Sent: Thursday, March 28, 2019 3:22 PM
To: haiyangz@linuxonhyperv.com
Cc: sashal@kernel.org; linux-hyperv@vger.kernel.org; Haiyang Zhang
[off-list ref]; KY Srinivasan [off-list ref]; Stephen
Hemminger [off-list ref]; olaf@aepfle.de; vkuznets
[off-list ref]; netdev@vger.kernel.org; linux-
kernel@vger.kernel.org
Subject: Re: [PATCH hyperv-fixes,v2] hv_netvsc: Fix unwanted wakeup after
tx_disable

From: Haiyang Zhang <redacted>
Date: Thu, 28 Mar 2019 19:16:37 +0000
quoted
From: Haiyang Zhang <haiyangz@microsoft.com>

After queue stopped, the wakeup mechanism may wake it up again when
ring buffer usage is lower than a threshold. This may cause send path
panic on NULL pointer when we stopped all tx queues in netvsc_detach
and start removing the netvsc device.

This patch fix it by adding a tx_disable flag to prevent unwanted
queue wakeup.

Fixes: 7b2ee50c0cd5 ("hv_netvsc: common detach logic")
Reported-by: Mohammed Gamal <redacted>
Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com>
Still need to fix the inline issues I mentioned in v1.
I will fix the inline issues. 

The haiyangz@linuxonhyperv.com cannot receive emails. 
My regular email is in the reply-to: field. 
Also, linuxonhyperv.com is being replaced by a new system soon.

Thanks.
- Haiyang
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help