Re: [PATCH] net-sysfs: Fix memory leak in netdev_register_kobject

On Tue, 19 Mar 2019 20:17:01 +0800
"wanghai (M)" [off-list ref] wrote:

+out:
         return error;
+register_error:
+       device_del(dev);
+device_add_error:
+       put_device(dev);
+       goto out;

Everything looks fine, but I would redo the last part without
the last goto out. Using a goto back to single return reduces
readability.

	if (error)
               goto register_error;
        
	pm_runtime_set_memalloc_noio(dev, true);
	return 0;

register_error:
      device_del(dev);
device_add_error:
       put_device(dev);
       return error;