Thread (11 messages) 11 messages, 3 authors, 2019-03-02

RE: [PATCH v3] net: e1000e: add MAC address kernel cmd line parameter

From: Flavio Suligoi <f.suligoi@asem.it>
Date: 2019-03-01 08:15:47
Also in: intel-wired-lan, lkml

quoted
quoted
quoted
Hi Flavio

u-boot should be able to write the MAC address in the correct part of
device tree. Boards have been doing this a long time.

Module parameters are considered bad. You should only do it if you
have no other option. Here you do have another options, so it is
going
quoted
quoted
quoted
to be a hard sell getting David to access your patch.

You will have more success by adding a call to
eth_platform_get_mac_address() to the e1000e driver.
You have right, and thanks for your suggestions,
but with a kernel parameter I can use the same method
for any board where the NVM is missed, independently of any
architecture
quoted
quoted
(with or without the device tree presence - ARM or x86 or others).
Hi Flavio

Well, lets wait for David to say what he thinks about the module
parameter.
I already rejected this, no way... Drivers that already have the
unacceptable module parameter are no an argument for spreading this
mistake further.
Hi David and Andrew,

ok, thank you for your suggestions and your time!

Flavio
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help