Re: [PATCH RFC 2/4] netlink: add generic object description infrastructure
From: Johannes Berg <johannes@sipsolutions.net>
Date: 2019-03-29 10:48:59
Also in:
netfilter-devel
On Wed, 2018-02-07 at 02:37 +0100, Pablo Neira Ayuso wrote:
quoted hunk ↗ jump to hunk
+++ b/include/net/net_namespace.h@@ -78,6 +78,7 @@ struct net { struct sock *rtnl; /* rtnetlink socket */ struct sock *genl_sock; + struct sock *nl_desc_sock;
Using genl would save that =)
+enum {
+ NLDESC_GET_CMDS = 16,
+ NLDESC_NEW_CMDS,I would say all of this new API should be in a new header file.
+enum nft_nldesc_req_attributes {nft_ prefix also doesn't seem appropriate.
+static int nl_desc_handle_msg(struct sk_buff *skb, struct nlmsghdr *nlh, + struct netlink_ext_ack *extack)
From here on it's also mostly boilerplate code that using genl handles :-) johannes