Re: [RFC v2 5/6] mlx4: report errors through extack
From: Jakub Kicinski <hidden>
Date: 2019-03-01 03:07:40
From: Jakub Kicinski <hidden>
Date: 2019-03-01 03:07:40
On Thu, 28 Feb 2019 13:54:40 -0800, Stephen Hemminger wrote:
@@ -2870,8 +2873,8 @@ static int mlx4_xdp_set(struct net_device *dev, struct bpf_prog *prog) if (port_up) { err = mlx4_en_start_port(dev); if (err) { - en_err(priv, "Failed starting port %d for XDP change\n", - priv->port); + NL_SET_ERR_MSG_MOD(extack, + "Failed starting port for XDP change");
alignment is off now in a few spots
queue_work(mdev->workqueue, &priv->watchdog_task); } }