Re: [PATCH v2 bpf-next 2/4] bpf: expose program stats via bpf_prog_info
From: Andrii Nakryiko <hidden>
Date: 2019-02-25 19:47:32
Also in:
bpf
On Sat, Feb 23, 2019 at 9:44 AM Alexei Starovoitov [off-list ref] wrote:
quoted hunk ↗ jump to hunk
Return bpf program runtime and runcnt via bpf_prog_info Signed-off-by: Alexei Starovoitov <ast@kernel.org> --- include/uapi/linux/bpf.h | 2 ++ kernel/bpf/syscall.c | 5 +++++ 2 files changed, 7 insertions(+)diff --git a/include/uapi/linux/bpf.h b/include/uapi/linux/bpf.h index bcdd2474eee7..d2cb85d85b39 100644 --- a/include/uapi/linux/bpf.h +++ b/include/uapi/linux/bpf.h@@ -2813,6 +2813,8 @@ struct bpf_prog_info { __u32 jited_line_info_rec_size; __u32 nr_prog_tags; __aligned_u64 prog_tags; + __u64 runtime; + __u64 runcnt; } __attribute__((aligned(8))); struct bpf_map_info {diff --git a/kernel/bpf/syscall.c b/kernel/bpf/syscall.c index 9a8c990c5df4..3405e0a4cf77 100644 --- a/kernel/bpf/syscall.c +++ b/kernel/bpf/syscall.c@@ -2152,6 +2152,7 @@ static int bpf_prog_get_info_by_fd(struct bpf_prog *prog, struct bpf_prog_info __user *uinfo = u64_to_user_ptr(attr->info.info); struct bpf_prog_info info = {}; u32 info_len = attr->info.info_len; + struct bpf_prog_stats stats; char __user *uinsns; u32 ulen; int err;@@ -2191,6 +2192,10 @@ static int bpf_prog_get_info_by_fd(struct bpf_prog *prog, if (err) return err; + bpf_prog_get_stats(prog, &stats); + info.runtime = stats.nsecs; + info.runcnt = stats.cnt; +
lgtm, but see naming discussion in other thread. Acked-by: Andrii Nakryiko <redacted>
if (!capable(CAP_SYS_ADMIN)) {
info.jited_prog_len = 0;
info.xlated_prog_len = 0;
--
2.20.0