Re: [PATCH v2] iwlwifi: mvm: Use div_s64 instead of do_div in iwl_mvm_debug_range_resp
From: Arnd Bergmann <arnd@arndb.de>
Date: 2019-02-22 08:52:44
Also in:
linux-wireless, lkml
On Fri, Feb 22, 2019 at 1:14 AM Nick Desaulniers [off-list ref] wrote:
On Thu, Feb 21, 2019 at 12:08 AM Nathan Chancellor [off-list ref] wrote:
One thing I'm curious about, is "why does do_div exist?" When should I use do_div vs div_u64 (not div_s64 as is used in this patch)?
I think do_div() is mostly historic, we've had it since the early days
when C compilers were not as good with inline functions. The various
other versions are regular functions, and I tend to prefer them for new
code, but do_div() is widely known and documented, so I have little
hope of it going away any time soon.
Arnd