Thread (47 messages) 47 messages, 5 authors, 2019-02-21

Re: [RFC PATCH net-next v3 08/21] ethtool: generic handlers for GET requests

From: Jakub Kicinski <hidden>
Date: 2019-02-20 02:42:57
Also in: lkml

On Mon, 18 Feb 2019 19:22:04 +0100 (CET), Michal Kubecek wrote:
+static struct common_req_info *alloc_get_data(const struct get_request_ops *ops)
nit: IMHO prefixing all structures and functions with a common phrase
     (ethnl) makes the code easier to navigate.
+{
+	struct common_req_info *req_info = kmalloc(ops->data_size, GFP_KERNEL);
+
+	if (!req_info)
+		return NULL;
nit: please avoid calling complex functions inline, especially if the
     result has to be error checked
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help