Thread (7 messages) 7 messages, 2 authors, 2019-02-15

RE: [PATCH net-next v2 3/3] enetc: Add ENETC PF level external MDIO support

From: Claudiu Manoil <claudiu.manoil@nxp.com>
Date: 2019-02-15 14:41:54
Also in: linux-arm-kernel, linux-devicetree, lkml

-----Original Message-----
From: Andrew Lunn <andrew@lunn.ch>
Sent: Friday, February 15, 2019 3:35 PM
To: Claudiu Manoil <claudiu.manoil@nxp.com>
Cc: Shawn Guo <shawnguo@kernel.org>; Leo Li <redacted>; David S .
Miller [off-list ref]; Alexandru Marginean
[off-list ref]; linux-arm-kernel@lists.infradead.org;
devicetree@vger.kernel.org; netdev@vger.kernel.org; linux-
kernel@vger.kernel.org
Subject: Re: [PATCH net-next v2 3/3] enetc: Add ENETC PF level external MDIO
support

On Fri, Feb 15, 2019 at 12:10:14PM +0200, Claudiu Manoil wrote:
quoted
Each ENETC PF has its own MDIO interface, the corresponding
MDIO registers are mapped in the ENETC's Port register block.
The current patch adds a driver for these PF level MDIO buses,
so that each PF can manage directly its own external link.

Signed-off-by: Alex Marginean <redacted>
Signed-off-by: Claudiu Manoil <claudiu.manoil@nxp.com>
---
v2 - used readx_poll_timeout()
   - added mdio node child to the port node
Hi Claudiu

Please document this in the device tree binding.
Hi,
I don't really see what bindings would need to be documented, as the node
names and properties used so far are common.  Like, the "mdio" node name
is common, the enetc ports are "pci" nodes, nothing special for these.
What's missing?

Regards,
Claudiu
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help