Re: [PATCH v2 1/2] iwlwifi: Use kmemdup instead of duplicating its function
From: Luciano Coelho <hidden>
Date: 2019-02-14 06:57:26
Also in:
linux-wireless, lkml
From: Luciano Coelho <hidden>
Date: 2019-02-14 06:57:26
Also in:
linux-wireless, lkml
On Tue, 2019-01-29 at 11:21 +0800, YueHaibing wrote:
Use kmemdup rather than duplicating its implementation Signed-off-by: YueHaibing <redacted> --- drivers/net/wireless/intel/iwlwifi/iwl-nvm-parse.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-)diff --git a/drivers/net/wireless/intel/iwlwifi/iwl-nvm-parse.cb/drivers/net/wireless/intel/iwlwifi/iwl-nvm-parse.c index d9afedc..569cc50 100644--- a/drivers/net/wireless/intel/iwlwifi/iwl-nvm-parse.c +++ b/drivers/net/wireless/intel/iwlwifi/iwl-nvm-parse.c@@ -1196,13 +1196,9 @@ iwl_parse_nvm_mcc_info(struct device *dev,const struct iwl_cfg *cfg, regd_to_copy = sizeof(struct ieee80211_regdomain) + valid_rules * sizeof(struct ieee80211_reg_rule); - copy_rd = kzalloc(regd_to_copy, GFP_KERNEL); - if (!copy_rd) { + copy_rd = kmemdup(regd, regd_to_copy, GFP_KERNEL); + if (!copy_rd) copy_rd = ERR_PTR(-ENOMEM); - goto out; - } - - memcpy(copy_rd, regd, regd_to_copy); out: kfree(regdb_ptrs);
This was already applied. Dropping. -- Luca.