Re: [PATCH 0/3] Add gup fast + longterm and use it in HFI1

On Mon, Feb 11, 2019 at 12:34:17PM -0800, Davidlohr Bueso wrote:

On Mon, 11 Feb 2019, ira.weiny@intel.com wrote:

quoted

Ira Weiny (3):
 mm/gup: Change "write" parameter to flags
 mm/gup: Introduce get_user_pages_fast_longterm()
 IB/HFI1: Use new get_user_pages_fast_longterm()

Out of curiosity, are you planning on having all rdma drivers
use get_user_pages_fast_longterm()? Ie:

hw/mthca/mthca_memfree.c:       ret = get_user_pages_fast(uaddr & PAGE_MASK, 1, FOLL_WRITE, pages);
hw/qib/qib_user_sdma.c:         ret = get_user_pages_fast(addr, j, 0, pages);

I missed that when I change the other qib call to longterm...  :-(

Yes both of these should be changed.  Although I need to look into Jasons
comment WRT the mthca call.

Ira

Thanks,
Davidlohr