On 1/31/19 8:11 AM, Chuck Lever wrote:

quoted

On Jan 30, 2019, at 7:46 PM, Gustavo A. R. Silva [off-list ref] wrote:

One of the more common cases of allocation size calculations is finding
the size of a structure that has a zero-sized array at the end, along
with memory for some number of elements for that array. For example:

struct foo {
   int stuff;
   struct boo entry[];
};

instance = kzalloc(sizeof(struct foo) + count * sizeof(struct boo), GFP_KERNEL);

Instead of leaving these open-coded and prone to type mistakes, we can
now use the new struct_size() helper:

instance = kzalloc(struct_size(instance, entry, count), GFP_KERNEL);

This code was detected with the help of Coccinelle.

Signed-off-by: Gustavo A. R. Silva <redacted>

Reviewed-by: Chuck Lever <chuck.lever@oracle.com>

Thanks, Chuck.

--
Gustavo