Thread (1 message) 1 message, 1 author, 2019-02-07

Re: [PATCH] net: stmmac: Variable "val" in function sun8i_dwmac_set_syscon() could be uninitialized

From: David Miller <davem@davemloft.net>
Date: 2019-02-07 17:53:59
Also in: linux-arm-kernel, lkml

From: Yizhuo Zhai <redacted>
Date: Wed, 6 Feb 2019 21:52:15 -0800
Thanks, but why initialization matters here? Is performance the main
concern?
Code that is unnecessary is hard to audit.

People will ask "why" is it initialized?  In what situations is the
initialized value of "0" ever used?

You are wasting people's time and energy by writing unnecessary code.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help