Re: [PATCH net-next] cxgb4: smt: use struct_size() in kvzalloc()
From: David Miller <davem@davemloft.net>
Date: 2019-02-01 23:23:16
Also in:
lkml
From: David Miller <davem@davemloft.net>
Date: 2019-02-01 23:23:16
Also in:
lkml
From: "Gustavo A. R. Silva" <redacted> Date: Wed, 30 Jan 2019 18:27:44 -0600
One of the more common cases of allocation size calculations is
finding the size of a structure that has a zero-sized array at
the end, along with memory for some number of elements for that
array. For example:
struct foo {
int stuff;
struct boo entry[];
};
instance = kvzalloc(sizeof(struct foo) + count * sizeof(struct boo), GFP_KERNEL);
Instead of leaving these open-coded and prone to type mistakes, we can now
use the new struct_size() helper:
instance = kvzalloc(struct_size(instance, entry, count), GFP_KERNEL);
This code was detected with the help of Coccinelle.
Signed-off-by: Gustavo A. R. Silva <redacted>Applied.