Thread (6 messages) 6 messages, 4 authors, 2019-02-01

Re: [PATCH net-next] nfp: use struct_size() in kzalloc()

From: David Miller <davem@davemloft.net>
Date: 2019-02-01 23:23:00
Also in: lkml

From: "Gustavo A. R. Silva" <redacted>
Date: Wed, 30 Jan 2019 18:38:59 -0600
One of the more common cases of allocation size calculations is finding
the size of a structure that has a zero-sized array at the end, along
with memory for some number of elements for that array. For example:

struct foo {
    int stuff;
    struct boo entry[];
};

instance = kzalloc(sizeof(struct foo) + count * sizeof(struct boo), GFP_KERNEL);

Instead of leaving these open-coded and prone to type mistakes, we can
now use the new struct_size() helper:

instance = kzalloc(struct_size(instance, entry, count), GFP_KERNEL);

This code was detected with the help of Coccinelle.

Signed-off-by: Gustavo A. R. Silva <redacted>
Applied.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help