Re: [PATCH net-next] cxgb4vf: Enter debugging mode if FW is inaccessible
From: David Miller <davem@davemloft.net>
Date: 2019-02-28 18:27:52
From: Arjun Vynipadath <redacted> Date: Thu, 28 Feb 2019 15:33:16 +0530
If we are not able to reach firmware, enter debugging mode that will help us to get adapter logs. Signed-off-by: Arjun Vynipadath <redacted> Signed-off-by: Vishal Kulkarni <redacted>
Applied, however I will say:
quoted hunk ↗ jump to hunk
@@ -411,6 +411,7 @@ enum { /* adapter flags */ USING_MSIX = (1UL << 2), QUEUES_BOUND = (1UL << 3), ROOT_NO_RELAXED_ORDERING = (1UL << 4), + FW_OK = (1UL << 5), };
These macros are asking for conflicts in the global namespace and could really use "CXGB4_XXX" prefixes.