On Thu, 28 Feb 2019 16:01:25 +0100, Jiri Pirko wrote:

Tue, Feb 26, 2019 at 04:34:02AM CET, jakub.kicinski@netronome.com wrote:

quoted

diff --git a/net/Kconfig b/net/Kconfig
index 62da6148e9f8..1efe1f9ee492 100644
--- a/net/Kconfig
+++ b/net/Kconfig

@@ -429,21 +429,12 @@ config NET_SOCK_MSG

	  with the help of BPF programs.

config NET_DEVLINK
-	tristate "Network physical/parent device Netlink interface"
+	bool "Network physical/parent device Netlink interface"  

Wouldn't "default y" be better?

No opinion.  It used to be 'n', it didn't change here..  But we can
change if we write convincing enough commit message :)

Did you see cases where people "forget" to enable it?

quoted

	help
	  Network physical/parent device Netlink interface provides
	  infrastructure to support access to physical chip-wide config and
	  monitoring.