Thread (20 messages) 20 messages, 3 authors, 2019-02-24

Re: [PATCH v2 iproute2-next 04/11] devlink: Add helper functions for name and value separately

From: Aya Levin <hidden>
Date: 2019-02-24 08:08:24

On 2/21/2019 4:08 PM, Jiri Pirko wrote:
Thu, Feb 21, 2019 at 02:42:40PM CET, ayal@mellanox.com wrote:
quoted
Add a new helper functions which outputs only values (without name
label) for different types: boolean, uint, uint64, string and binary.
In addition add a helper function which prints only the name label.

Signed-off-by: Aya Levin <redacted>
Reviewed-by: Moshe Shemesh <redacted>
---
devlink/devlink.c | 66 ++++++++++++++++++++++++++++++++++++++++++++++++++++++-
1 file changed, 65 insertions(+), 1 deletion(-)
diff --git a/devlink/devlink.c b/devlink/devlink.c
index b073ae020d52..5d69c4f24f29 100644
--- a/devlink/devlink.c
+++ b/devlink/devlink.c
@@ -1588,7 +1588,6 @@ static void pr_out_port_handle_end(struct dl *dl)
		pr_out("\n");
}

-
Please avoid changes like this.
Thanks,
Will fix in next version

[...]
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help