Re: [PATCH 3/3 net-next] test_objagg: Uninitialized variable in error handling

From
Jiri Pirko <jiri@resnulli.us>
Date
2019-02-13 13:26:17
Also in
kernel-janitors
Reply to
Dan Carpenter, 2019-02-13
Wed, Feb 13, 2019 at 09:59:31AM CET, dan.carpenter@oracle.com wrote:
We need to set the error message on this path otherwise some of the
callers, such as test_hints_case(), print from an uninitialized pointer.

We had a similar bug earlier and set "errmsg" to NULL in the caller,
test_delta_action_item().  That code is no longer required so I have
removed it.

Fixes: 9069a3817d82 ("lib: objagg: implement optimization hints assembly and use hints for object creation")
Signed-off-by: Dan Carpenter <redacted>
Acked-by: Jiri Pirko <redacted>
Thread (9 messages) 9 messages, 3 authors, last reply 2019-02-14
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help