Re: [PATCH 01/12 net-next,v7] flow_offload: add flow_rule and flow_match structures and use them

Sat, Feb 02, 2019 at 12:50:43PM CET, pablo@netfilter.org wrote:

This patch wraps the dissector key and mask - that flower uses to
represent the matching side - around the flow_match structure.

To avoid a follow up patch that would edit the same LoCs in the drivers,
this patch also wraps this new flow match structure around the flow rule
object. This new structure will also contain the flow actions in follow
up patches.

This introduces two new interfaces:

bool flow_rule_match_key(rule, dissector_id)

that returns true if a given matching key is set on, and:

flow_rule_match_XYZ(rule, &match);

To fetch the matching side XYZ into the match container structure, to
retrieve the key and the mask with one single call.

Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
---
v7: rebase on top of net-next. Dropping previous Acked-by tags since
   this one is slightly large, and it would be good another look after
   this rebase.

Looks good to me.

Acked-by: Jiri Pirko <redacted>