Re: [PATCH bpf-next v5 5/8] xdp: Provide extack messages when prog attachment failed
From: Jakub Kicinski <hidden>
Date: 2019-02-01 03:11:16
On Fri, 1 Feb 2019 01:19:51 +0100, Maciej Fijalkowski wrote:
if (__dev_xdp_query(dev, bpf_chk, XDP_QUERY_PROG) ||
- __dev_xdp_query(dev, bpf_chk, XDP_QUERY_PROG_HW))
+ __dev_xdp_query(dev, bpf_chk, XDP_QUERY_PROG_HW)) {
+ NL_SET_ERR_MSG(extack, "native and generic XDP can't be active at the same time");
return -EEXIST;
+ }
This reminds me, since we allowed native/driver and offloaded XDP
programs to coexist in a25717d2b604 ("xdp: support simultaneous
driver and hw XDP attachment") I got an internal feature request
to also allow generic and native mode. Would anyone object to that?
Apart from a touch up to test_offload.py I don't think anything
would care. netlink can already carry multiple IDs, iproute2
understands it, too..
(Obviously as a follow up after this set gets merged.)