Thread (11 messages) 11 messages, 5 authors, 2019-02-06

Re: [PATCH net] net/mlx4_en: Force CHECKSUM_NONE for short ethernet frames

From: Saeed Mahameed <hidden>
Date: 2019-02-01 00:05:17

On Thu, 2019-01-31 at 11:42 -0800, Eric Dumazet wrote:
On Thu, Jan 31, 2019 at 11:27 AM Saeed Mahameed [off-list ref]
wrote:
quoted
Are you sure ? you are claiming that the hardware will skip csum
complete i.e cqe->checksum will be 0xffff for padded short IP
frames.
i don't think this is the case, the whole bug is that the hw does
provide a partial cqe->checksum (i.e doesn't included the padding
bytes) even for short eth frames.
If the padding is not included, then cqe->checksum is 0xFFFF for
correctly received frames.

Otherwise, what would be cqe->checksum in this case ? A random value
?
the actual checksum of IP headers+IP payload, while ignoring the
padding bytes, which is the bug, let me double check..

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help