Re: [PATCH] iwlwifi: eeprom-parse: use struct_size() in kzalloc()
From: Gustavo A. R. Silva <hidden>
Date: 2019-01-29 16:50:21
Also in:
linux-wireless, lkml
From: Gustavo A. R. Silva <hidden>
Date: 2019-01-29 16:50:21
Also in:
linux-wireless, lkml
On 1/22/19 4:58 AM, Luciano Coelho wrote:
On Tue, 2019-01-08 at 11:17 -0600, Gustavo A. R. Silva wrote:quoted
One of the more common cases of allocation size calculations is finding the size of a structure that has a zero-sized array at the end, along with memory for some number of elements for that array. For example: struct foo { int stuff; void *entry[]; }; instance = kzalloc(sizeof(struct foo) + sizeof(void *) * count, GFP_KERNEL); Instead of leaving these open-coded and prone to type mistakes, we can now use the new struct_size() helper: instance = kzalloc(struct_size(instance, entry, count), GFP_KERNEL); This code was detected with the help of Coccinelle. Signed-off-by: Gustavo A. R. Silva <redacted> ---Applied to our internal tree, thanks! It will reach the mainline following our normal upstreaming process.
Great. :) Thanks, Luca. -- Gustavo