Thread (2 messages) 2 messages, 2 authors, 2019-01-17

Re: [PATCH net-next] cxgb4/l2t: Use struct_size() in kvzalloc()

flat view

From: David Miller <davem@davemloft.net>
Date: 2019-01-17 05:11:56
Also in: lkml

From: "Gustavo A. R. Silva" <redacted>
Date: Tue, 15 Jan 2019 15:44:52 -0600
One of the more common cases of allocation size calculations is finding the
size of a structure that has a zero-sized array at the end, along with memory
for some number of elements for that array. For example:

struct foo {
    int stuff;
    struct boo entry[];
};

instance = kvzalloc(sizeof(struct foo) + count * sizeof(struct boo), GFP_KERNEL);

Instead of leaving these open-coded and prone to type mistakes, we can now
use the new struct_size() helper:

instance = kvzalloc(struct_size(instance, entry, count), GFP_KERNEL);

This code was detected with the help of Coccinelle.

Signed-off-by: Gustavo A. R. Silva <redacted>
Applied.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help