Thread (2 messages) 2 messages, 2 authors, 2019-01-16

Re: [PATCH net-next] mlxsw: spectrum_acl_bloom_filter: use struct_size() in kzalloc()

flat view

From: David Miller <davem@davemloft.net>
Date: 2019-01-16 17:12:57
Also in: lkml

From: "Gustavo A. R. Silva" <redacted>
Date: Tue, 15 Jan 2019 17:05:39 -0600
One of the more common cases of allocation size calculations is finding
the size of a structure that has a zero-sized array at the end, along
with memory for some number of elements for that array. For example:

struct foo {
    int stuff;
    void *entry[];
};

instance = kzalloc(sizeof(struct foo) + sizeof(void *) * count, GFP_KERNEL);

Instead of leaving these open-coded and prone to type mistakes, we can
now use the new struct_size() helper:

instance = kzalloc(struct_size(instance, entry, count), GFP_KERNEL);

This issue was detected with the help of Coccinelle.

Reviewed-by: Ido Schimmel <redacted>
Signed-off-by: Gustavo A. R. Silva <redacted>
Applied.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help