Re: [RFC PATCH 1/5] net: lorawan: Refine the coding style

Am 16.01.19 um 15:33 schrieb Jiri Pirko:

Wed, Jan 16, 2019 at 03:24:54PM CET, starnight@g.ncu.edu.tw wrote:

quoted

Signed-off-by: Jian-Hong Pan <redacted>
---

Patches like this are in general frowned upon. Do one change in one
patch. Put some patch description.

This patch simply shouldn't have gone to netdev and LKML, as it is a
fixup against a non-stable tree (missing "lora-next"). Once squashed, it
doesn't matter whether it once had a verbose explanation or not. And I
prefer to not mix style and functional changes.

I simply was too impatient to wait for more respins before being able to
base work on it. ;)

Cheers,
Andreas

-- 
SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)