Re: [RFC net-next 11/15] net: lora: Add IMST WiMOD
From: Heinrich Schuchardt <hidden>
Date: 2019-01-06 14:58:47
Also in:
linux-arm-kernel, lkml
On 7/1/18 1:08 PM, Andreas Färber wrote:
quoted hunk ↗ jump to hunk
The IMST WiMOD uses a SLIP based binary UART protocol. Two separate firmwares are available. By default it ships with a LoRaWAN firmware. The alternative firmware is a custom P2P addressing mode based on LoRa. Cc: Jon Ortego <redacted> Signed-off-by: Andreas Färber <afaerber@suse.de> --- drivers/net/lora/Kconfig | 8 + drivers/net/lora/Makefile | 3 + drivers/net/lora/wimod.c | 597 ++++++++++++++++++++++++++++++++++++++++++++++ 3 files changed, 608 insertions(+) create mode 100644 drivers/net/lora/wimod.cdiff --git a/drivers/net/lora/Kconfig b/drivers/net/lora/Kconfig index 940bd2cbe106..2e05caef8645 100644 --- a/drivers/net/lora/Kconfig +++ b/drivers/net/lora/Kconfig@@ -31,6 +31,14 @@ config LORA_SX1276 help Semtech SX1272/1276/1278 +config LORA_WIMOD + tristate "IMST WiMOD driver"
scripts/checkpatch.pl throws this warning: WARNING: please write a paragraph that describes the config symbol fully IMST has multiple products related to "WiMOD": * WiMOD iC880A * WiMOD module iM871A * WSA01-iM880B - WiMOD Shield for Arduino * iM880B-L - Long Range Radio Module And IMST is not very consistent about what is called "WiMOD". So this leaves me clueless concerning what this Kconfig option is about. Please, provide a description. There are dozens of warnings given by scripts/checkpatch. Please, have a look at them. Best regards Heinrich _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel